Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consensus] LocalNet fails to prepare first block when pacemaker_config.manual is false #965

Open
4 tasks
red-0ne opened this issue Aug 3, 2023 · 2 comments
Assignees
Labels
consensus Consensus specific changes

Comments

@red-0ne
Copy link

red-0ne commented Aug 3, 2023

Objective

Have LocalNet building the first block without error when pacemaker manual mode is false.

When setting manual to false in charts/pocket/values.yaml

config:
  consensus:
    pacemaker_config:
      manual: false

And starting the network with make localnet_up, the leader fails to build the first block with the following error:

{"level":"info","module":"leader_utility_UOW","maxTxBytes":500000000,"proposer":"00104055c00bed7c983a48aac7dc6335d7c607a7","source":"CreateProposalBlock","state_hash":"07cf4c8d390c7dd608ea089aa87bf1e0e74992b98a62edcea4c115221f7e58a3","time":"2023-08-03T18:21:33Z","message":"Finished successfully"}
{"level":"info","module":"persistence","height":-1,"time":"2023-08-03T18:21:33Z","message":"About to release context"}
{"level":"error","module":"consensus","kind":"LEADER","error":"no rows in result set","time":"2023-08-03T18:21:33Z","message":"could not prepare block"}
{"level":"warn","module":"pacemaker","height":0,"round":16,"step":1,"time":"2023-08-03T18:21:33Z","message":"⏰ Interrupt ⏰ due to: failed to prepare new block"}

But after manually triggering the next view from debug CLI, blocks start being produced correctly.

Deliverable

  • Fix first block preparation when consensus' pacemaker manual is set to false

Testing Methodology

  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
  • k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: @red-0ne
Co-Owners:

@red-0ne red-0ne added the consensus Consensus specific changes label Aug 3, 2023
@Olshansk
Copy link
Member

Olshansk commented Aug 3, 2023

@red-0ne Please make sure to update metadata (iteration, effort, assignee) for all issues.

Screenshot 2023-08-03 at 12 12 43 PM

@red-0ne
Copy link
Author

red-0ne commented Aug 3, 2023

Thanks for the reminder, it always gets me because I don't have the (iteration, effort) when I create the issue.

@red-0ne red-0ne self-assigned this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Consensus specific changes
Projects
Status: Backlog
Development

No branches or pull requests

2 participants