Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance spo file roleassignment commands with Microsoft Entra groups #6197

Open
2 tasks
milanholemans opened this issue Jul 27, 2024 · 5 comments · May be fixed by #6431
Open
2 tasks

Enhance spo file roleassignment commands with Microsoft Entra groups #6197

milanholemans opened this issue Jul 27, 2024 · 5 comments · May be fixed by #6431
Assignees
@ktskumar
Labels
enhancement hacktoberfest Issue perfect for hacktoberfest work in progress

Comments

@milanholemans
Copy link
Contributor

Related to #6179

Let's extend command spo file roleassignment add and spo file roleassignment remove with 2 new options to add/remove Microsoft Entra groups.

Options Description
--entraGroupId [entraGroupId] ID of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...
--entraGroupName [entraGroupName] Display name of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...

Additionally, we should update the description of option --groupName [groupName] and make clear that this option is only used for SharePoint Online groups.

Todo:

  • Introduce 2 new options to add and remove command.
  • Clarify that option groupName is only for SharePoint Online groups.
@milanholemans milanholemans added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Jul 27, 2024
@Jwaegebaert Jwaegebaert added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Jul 31, 2024
@Adam-it Adam-it added the hacktoberfest Issue perfect for hacktoberfest label Sep 24, 2024
@ktskumar
Copy link
Contributor

May I work on this

@Jwaegebaert
Copy link
Contributor

Jwaegebaert commented Sep 26, 2024 •
edited
Loading

Hey @ktskumar, thank you for all the hard work you’ve put in, it’s really appreciated! We’ve noticed that you have several issues assigned that haven't yet been created with a PR. To ensure everyone has a chance to get involved, especially with Hacktoberfest, I’ll be unassigning you from some of these issues.

We recommend focusing on 1 to 2 issues at a time. Once you’ve submitted a PR for an issue, you can easily claim another open one. This approach helps you manage the workload more effectively and ensures you can give each task the attention it needs.

Thanks again for your continued contributions!

@ktskumar
Copy link
Contributor

ktskumar commented Oct 8, 2024

May I work on this

@milanholemans
Copy link
Contributor Author

milanholemans commented Oct 8, 2024 •
edited
Loading

Hi, @ktskumar, you can work on it when you've solved another issue, all right?

@ktskumar
Copy link
Contributor

I'll take this up. Can you assign this to me

@ktskumar ktskumar linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktskumar ktskumar

Labels
enhancement hacktoberfest Issue perfect for hacktoberfest work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance spo file roleassignment command ktskumar/cli-microsoft365
4 participants
@milanholemans @ktskumar @Jwaegebaert @Adam-it