Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: m365 spp model remove #6118

Open
Tracked by #6074
mkm17 opened this issue Jul 4, 2024 · 8 comments · May be fixed by #6410
Open
Tracked by #6074

New command: m365 spp model remove #6118

mkm17 opened this issue Jul 4, 2024 · 8 comments · May be fixed by #6410
Assignees
Labels

Comments

@mkm17
Copy link
Contributor

mkm17 commented Jul 4, 2024

Usage

m365 spp model remove [options]

Description

Delete a SharePoint Premium document understanding model

Options

Option Description
-u, --siteUrl <siteUrl> The URL of the content center site.
-i, --id [id] The unique ID of the model to delete. Specify either id or title but not both.
-t, --title [title] The display name (case-sensitive) of the model to remove. Specify either id or title but not both.
-f, --force Don't prompt for confirming removing the model.

Examples

Delete a SharePoint Premium document understanding model using the model’s UniqueId.

m365 spp model remove --siteUrl "https://contoso.sharepoint.com/sites/ContentCenter" --id "7645e69d-21fb-4a24-a17a-9bdfa7cb63dc"

Delete a SharePoint Premium document understanding model using the model’s title.

m365 spp model remove --siteUrl "https://contoso.sharepoint.com/sites/ContentCenter" --title "climicrosoft365Model"

Remarks

Note that this model will be removed from all libraries before it can be deleted.

Additional Info

These two endpoints should be used:

@Adam-it Adam-it added needs peer review Needs second pair of eyes to review the spec or PR feature request labels Jul 5, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Jul 5, 2024

LGTM to me 👍👍.
I would only use id instead of uniqueId

@pnp/cli-for-microsoft-365-maintainers any other feed on that?

@mkm17 mkm17 changed the title New command: m365 spo stx model remove New command: m365 spo premium model remove Jul 9, 2024
@Jwaegebaert
Copy link
Contributor

We'll need to add a few additional remarks for this command it seems. If I read the docs right, it stated that the model needs to be removed from every library before you can delete it. So that seems like something we should best notify the users about in the docs. First, I thought we needed to also specify each library where it is applied before we can delete it but it seems that there is an "easy" endpoint we can call to get all the needed information: https://learn.microsoft.com/en-us/sharepoint/dev/apis/syntex/rest-getmodelandlibraryinfo. With this result, we can make sure that the model is removed from all libraries and then delete it.

  • Also, let's replace all the occurrences of Syntex with SharePoint Premium. 😉
  • One smaller detail, in your examples, there are two spaces between your command and the first option. remove --siteUrl
  • The section default properties can also be removed as we won't need it here.

@mkm17
Copy link
Contributor Author

mkm17 commented Jul 10, 2024

hi @Jwaegebaert thank you for all comments. I have added the Remark section to the command, I hope that it will be ok.

@Jwaegebaert
Copy link
Contributor

Awesome, nothing further to add. Do you want to work on it or open it up?

@waldekmastykarz
Copy link
Member

I suggest we reconsider naming. Since we use spe to indicate SharePoint Embedded, shouldn't we use spp to indicate SharePoint Premium? Premium is not a feature set, it's a licensing SKU, right? I suggest that we treat it consistently as a product/workload.

@mkm17
Copy link
Contributor Author

mkm17 commented Jul 12, 2024

@Jwaegebaert yes I can take it :)
@waldekmastylkarz let me copy your comment to the place where we had the discussion about the naming.

@stevecorey365
Copy link

I agree with @waldekmastykarz. Great idea!

@mkm17 mkm17 changed the title New command: m365 spo premium model remove New command: m365 spp model remove Jul 16, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Jul 23, 2024

@mkm17 perfect 🤩.
lets 🚀 this

@Adam-it Adam-it added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Jul 23, 2024
@Adam-it Adam-it added the hacktoberfest Issue perfect for hacktoberfest label Sep 24, 2024
mkm17 added a commit to mkm17/cli-microsoft365 that referenced this issue Oct 3, 2024
mkm17 added a commit to mkm17/cli-microsoft365 that referenced this issue Oct 6, 2024
@mkm17 mkm17 linked a pull request Oct 6, 2024 that will close this issue
mkm17 added a commit to mkm17/cli-microsoft365 that referenced this issue Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants