Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add the properties option to entra group/app/administrativeunit get/list commands #6315

Open
MartinM85 opened this issue Sep 5, 2024 · 6 comments · May be fixed by #6394
Open

Enhancement: Add the properties option to entra group/app/administrativeunit get/list commands #6315

MartinM85 opened this issue Sep 5, 2024 · 6 comments · May be fixed by #6394
Assignees
@nanddeepn
Labels
enhancement hacktoberfest Issue perfect for hacktoberfest work in progress

Comments

@MartinM85
Copy link
Contributor

MartinM85 commented Sep 5, 2024 •
edited
Loading

Directory extensions allow to add custom data to Entra objects:

To be able to read the directory extension, the commands must support the properties option, which allows to specify the name of directory extension to be retrieved.

Currently, only these commands have the properties option and return the extension property:

  • entra user get
  • entra user list

Add the properties option to the following commands:

  • entra group get
  • entra group list
  • entra app get
  • entra app list
  • entra administrativeunit get
  • entra administrativeunit list
Option Description
-p, --properties [properties] Comma-separated list of properties to retrieve
@milanholemans milanholemans added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Sep 6, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Sep 10, 2024

good idea. Also we should use the short option naming when possible like -p, --properties [properties].
@pnp/cli-for-microsoft-365-maintainers anyone else have any other feed before we open it up?

@milanholemans
Copy link
Contributor

As Adam pointed out, let's use -p indeed.

@MartinM85
Copy link
Contributor Author

-p added

@Adam-it Adam-it added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Sep 11, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Sep 11, 2024

Awesome. Lets open it up 🚀

@Adam-it Adam-it added the hacktoberfest Issue perfect for hacktoberfest label Sep 24, 2024
@nanddeepn
Copy link
Contributor

Can I work on it?

As we are targeting to return the extension property, it should be entra group get instead of entra group set?

@MartinM85
Copy link
Contributor Author

Can I work on it?

As we are targeting to return the extension property, it should be entra group get instead of entra group set?

@nanddeepn Yes, it should be entra group get. Fixed.

@nanddeepn nanddeepn linked a pull request Sep 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanddeepn nanddeepn

Labels
enhancement hacktoberfest Issue perfect for hacktoberfest work in progress
Projects
None yet
Milestone
No milestone
5 participants
@MartinM85 @nanddeepn @milanholemans @Jwaegebaert @Adam-it