249 prepopulate installer information when creating a project #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange for the fields doesn't work.
…irects to the home page.
…st recent project modified.
…state and photo are not autofilling yet.
…ept email, state and photo.
…lating. There is a bug in editing a project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW UI CREATED:
When user clicks New Project:
They will see the New Project form and it will pre-populate the Installer Information with the data from the last project they edited or created
There will be a drop down menu where they can choose from a list of previously entered installer information, they can also clear the Installer Fields from this drop down
If there is no previously-created project, the drop down does not show up and the Installer Fields do not pre-populate
If the user is editing a project instead of creating a new one, the drop down does not show up and ALL the fields populate with that project's data from the database
I also noticed this bug where the user could submit an invalid form:
Screen.Recording.2025-01-08.at.4.41.21.PM.mov
SUGGESTIONS FOR NEXT STEPS:
Because there are quite a few differences between how the "new project" and "edit project" forms work, there is a lot of conditional logic switching things on and off. I might suggest creating an entirely different route (maybe /app/{id-number}/edit) and a separate EditProject component for editing an existing project. I think that this would make the code easier to read and work on in the future.
Some other things I noticed in the UI:
*Would be nice to have a "Home" button (could even hyperlink the "Quality Install Tool" header so that it directs to the root route.
*Would be nice to have a "Back" button at the top of the New Project or Edit Project form. I found myself clicking the back button on the browser from this page and it doesn't work as I expected. Maybe we should change that too? I think it might be coming from the way we are navigating here with
replace:true:Screen.Recording.2025-01-08.at.4.33.38.PM.mov
*Could clean up the display of addresses when it's not fully filled out (note the comma after City Name):