Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeploying/releasing on apps:rename/fork #4

Open
stuartpb opened this issue Aug 7, 2014 · 1 comment
Open

Redeploying/releasing on apps:rename/fork #4

stuartpb opened this issue Aug 7, 2014 · 1 comment

Comments

@stuartpb
Copy link
Member

stuartpb commented Aug 7, 2014

Right now apps:rename does a redeploy, and apps:fork does a rerelease and a redeploy. This should arguably be done by having the relevant parts of a redeploy/release handled by rename-app/fork-app hooks in the relevant release and deploy plugins (as rerelease-and-redeploy may be better accomplished by different means when renaming or forking).

@stuartpb stuartpb changed the title Redeploying on apps:rename Redeploying/releasing on apps:rename/fork Aug 7, 2014
@stuartpb
Copy link
Member Author

As an example, apps:fork does not do a rebuild, because buildstep handles forking builds differently (it creates a cheap copy of the existing build image).

Indeed, the idea that a rename doesn't require a redeploy (or even a rebuild!) is a little presumptive (who says there isn't a plugin that adds the app's name to the environment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant