Adding new text block via dropdown when current block is empty #6580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
@stevepiercy @sneridagh provide review on this. |
stevepiercy
requested changes
Jan 12, 2025
packages/volto/news/6574.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Implemented functionality to add a new text block via the dropdown menu, even when the current text block is empty. @Abhishek-17h | |||
There was a problem hiding this comment.
Suggested change
| Implemented functionality to add a new text block via the dropdown menu, even when the current text block is empty. @Abhishek-17h | |
| You can now add a text block by clicking the circled `+` icon ("Add" block button) and selecting "Text" from the pop-up menu. Previously no text block would be inserted. @Abhishek-17h |
|
This is nice work. Let's get the @plone/volto-team and @plone/volto-accessibility teams to give a technical review before merging. |
davisagli
reviewed
Jan 12, 2025
| onMutateBlock(block, { ...data, ...value }); | ||
| setAddNewBlockOpened(false); | ||
| } else { | ||
| setAddNewBlockOpened(false); |
There was a problem hiding this comment.
Please move setAddNewBlockOpened(false); outside of the conditional, since it's done in both branches and the order doesn't matter.
Abhishek-17h
force-pushed
the
feature/enable-dropdown-for-empty-text-block
branch
from
82efe76 to
4629722
Compare
davisagli
reviewed
Jan 12, 2025
Abhishek-17h
force-pushed
the
feature/enable-dropdown-for-empty-text-block
branch
from
4629722 to
6b0dcb7
Compare
|
@davisagli @stevepiercy Please have a look now. |
stevepiercy
reviewed
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The video showcases the behavior after the feature for clarity:
Screencast from 2025-01-12 12-21-31.webm
Closes #6574