Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate fails to identify missing disk property #146

Open
gilzow opened this issue Aug 30, 2023 · 2 comments
Open

validate fails to identify missing disk property #146

gilzow opened this issue Aug 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@gilzow
Copy link
Contributor

gilzow commented Aug 30, 2023

Related to testing in #145, after correcting the mount source_path issue, validate failed to identify that I had added a mount, but had not added a disk property to the config, which resulted in

  E: Error parsing configuration files:
      - applications./.platform.app.yaml: The application "platformify_cookies" is diskless but defines local mounts and such mounts require disks. This means the configuration has to have a "disk" key with an integer value greater or equal to 128.

when attempting to push the change.

@akalipetis akalipetis added the bug Something isn't working label Sep 18, 2023
@akalipetis
Copy link
Member

Thanks for reporting @gilzow - currently we only validate the static schema - this is a dynamic property and should definitely be handled in the future.

@akalipetis
Copy link
Member

This should also take into account things like missing service names, etc.

For example (submitted by @devicezero):

Add a service:

    mounts:
      "/foobar":
        source: "service"
        source_path: "foobar"

Pushing the code will fail validation on the git side with:

 E: Error parsing configuration files:
    - applications.config.yaml:express.mounts./foobar: When source is 'service', a service name is required. Set `service: <service name>` to specify the service that will provide the networked mount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants