Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disjoined regions to be highlighted together #415

Open
NyalephTheCat opened this issue Jul 24, 2023 · 4 comments
Open

Allow disjoined regions to be highlighted together #415

NyalephTheCat opened this issue Jul 24, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@NyalephTheCat
Copy link
Contributor

Describe the solution

At the moment, you need to add a tiny line between two regions of the canvas that are related.
I suggest to add the possibility to make multiple polygons in one request that would highlight at the same time on hover.

@NyalephTheCat NyalephTheCat added the enhancement New feature or request label Jul 24, 2023
@Hans5958
Copy link
Member

Hans5958 commented Jul 24, 2023

I'd assume you want to draw two or more polygons for one entry in the same period.

This is technically possible (albeit it would need quite an huge work, code side, so don't expect this in the near future), but one thing I'm afraid of is the user interface. What do you think is the best way so people can switch between two paths/polygons, so people don't get confused?

@NyalephTheCat
Copy link
Contributor Author

maybe a button add path that allows you to add a path like you can add timelines maybe?

@mxdanger
Copy link
Member

If users are able to draw multiple separate paths we would need the following:

  • Keybind or button that finalizes the looped path and allows you to start a new one. Possibility with a limit of 2.
  • Each path would need a calculated center point.
  • UI would draw a line to both center points.
  • JSON schema and parser would need to be reworked to account for simultaneous timeline history for multiple paths at the same time.
  • Editor would need to be reworked to support this, wether the paths are treated as the same instance in the timeline or separate and independent.
  • Rendering outline would be updated to support more than one.

@Hans5958
Copy link
Member

Hans5958 commented Jul 24, 2023

maybe a button add path that allows you to add a path like you can add timelines maybe?

Note that adding a period (as you said "a timeline") is necessarily just adding a polygon (or "an area"), which periods couldn't intersect.


One thing to note, for now, it is recommended to do separate entries.1 Who knows when in the future we got this working and be able to merge entries?2

Footnotes

  1. I would expect each entry have something different, especially the history (who drew it, why two, etc)

  2. No high hopes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants