Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ui-library unit tests on CI #9951

Closed
jardakotesovec opened this issue May 9, 2024 · 5 comments
Closed

Run ui-library unit tests on CI #9951

jardakotesovec opened this issue May 9, 2024 · 5 comments
Assignees
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

jardakotesovec commented May 9, 2024

Describe the issue
There is increasing number of unit tests in ui-library and it would be great to include them in CI run as well

To to run them it requires to run following in ui-library folder

npm install
npm run test
@jardakotesovec jardakotesovec added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label May 9, 2024
@jardakotesovec jardakotesovec added this to the 3.5 Internal milestone May 9, 2024
@jardakotesovec
Copy link
Contributor Author

@withanage Hi Dulip, do you think you could help to add it to github actions?

@withanage
Copy link
Member

@jardakotesovec sure, I will implement that.

@jardakotesovec
Copy link
Contributor Author

@withanage
Hi Dulip,
can just quickly review this one - pkp/ui-library#351

But it seems to be working, so could we move it from withanage/pkp-ui-library-action@main to pkp account before merging?

Thank you

@withanage
Copy link
Member

@jardakotesovec ,

Hi Jarda, I moved the pkp-ui-library-action to pkp namespace and left you a comment there ?

@jardakotesovec
Copy link
Contributor Author

@withanage Its merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Development

No branches or pull requests

2 participants