Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OMP - Empty category missing locale key #9722

Closed
israelcefrin opened this issue Feb 11, 2024 · 2 comments
Closed

OMP - Empty category missing locale key #9722

israelcefrin opened this issue Feb 11, 2024 · 2 comments
Assignees
@israelcefrin
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.3.0-19

Comments

@israelcefrin
Copy link
Collaborator

Describe the bug
When a category in OMP is empty (has 0 titles associated to it) it shows a missing locale key error instead a translated message.

To Reproduce
Steps to reproduce the behavior:

  1. Go to OMP 3.3 Demo
  2. Click on 'Business & Economics ' (or any empty category)
  3. See error

What application are you using?
OMP 3.2 / 3.3 / 3.4

Additional information
image

OJS 1.2 still has the original locale key message:
https://github.com/pkp/omp/blob/omp-stable-1_2_0/locale/en_US/locale.xml#L289C16-L289C39
@israelcefrin israelcefrin self-assigned this Feb 11, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Jul 24, 2024
@kaitlinnewson
pkp/pkp-lib#9722 missing locale key for empty categories
1d041df
@kaitlinnewson
Copy link
Member

Fixed in pkp/omp#986, back-porting PR for review @asmecher:

@jonasraoni jonasraoni added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jul 25, 2024
@jonasraoni jonasraoni added this to the 3.3.0-19 milestone Jul 25, 2024
asmecher pushed a commit to pkp/omp that referenced this issue Aug 8, 2024
@kaitlinnewson @asmecher
pkp/pkp-lib#9722 missing locale key for empty categories
e131ad6
@asmecher
Copy link
Member

asmecher commented Aug 8, 2024

Merged, thanks!

@asmecher asmecher closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@israelcefrin israelcefrin

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.3.0-19
Development

No branches or pull requests
4 participants
@asmecher @jonasraoni @israelcefrin @kaitlinnewson