Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize PKPRouter::initialize() calls #10823

Closed
jonasraoni opened this issue Jan 19, 2025 · 0 comments · Fixed by pkp/ojs#4612, #10824 or pkp/omp#1814
Closed

Standardize PKPRouter::initialize() calls #10823

jonasraoni opened this issue Jan 19, 2025 · 0 comments · Fixed by pkp/ojs#4612, #10824 or pkp/omp#1814
Assignees
@jonasraoni
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5 Internal

Comments

@jonasraoni
Copy link
Contributor

Describe the bug
Most of the code is using public function initialize($request, $args = null), but some are using public function initialize($request), it's actually not breaking anything at the moment.

What application are you using?
OJS main
@jonasraoni jonasraoni added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Jan 19, 2025
@jonasraoni jonasraoni added this to the 3.5 Internal milestone Jan 19, 2025
@jonasraoni jonasraoni self-assigned this Jan 19, 2025
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 19, 2025
@jonasraoni
pkp#10823 Fixed validate call
a7893ad
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 19, 2025
@jonasraoni
pkp#10823 Typed remaining methods
5cf718c
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 19, 2025
@jonasraoni
pkp#10823 Added possibly missing argument
80d0e84
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 19, 2025
@jonasraoni
pkp#10823 Standardized remaining calls
e6c8a97
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 19, 2025
@jonasraoni
pkp#10823 Fixed notice warning
dfae6bd
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 19, 2025
@jonasraoni
pkp/pkp-lib#10823 Standardized PKPRouter::initialize() call
9249ed5
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 19, 2025
@jonasraoni
pkp/pkp-lib#10823 Submodule Update ##jonasraoni/bugfix-main-10823-sta…
efbacb8 
…ndardize-pkprouter-initialization##
This was linked to pull requests Jan 19, 2025
Bugfix main 10823 standardize pkprouter initialization pkp/ojs#4612
Merged
Bugfix main 10823 standardize pkprouter initialization #10824
Merged
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jan 19, 2025
@jonasraoni
pkp/pkp-lib#10823 Standardized PKPRouter::initialize() call
fda803c
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jan 19, 2025
@jonasraoni
pkp/pkp-lib#10823 Submodule Update ##jonasraoni/bugfix-main-10823-sta…
8a53d02 
…ndardize-pkprouter-initialization##
@jonasraoni jonasraoni linked a pull request Jan 20, 2025 that will close this issue
Bugfix main 10823 standardize pkprouter initialization pkp/omp#1814
Merged
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 20, 2025
@jonasraoni
pkp#10823 Fixed validate call
73e3623
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 20, 2025
@jonasraoni
pkp#10823 Typed remaining methods
0cf9a95
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 20, 2025
@jonasraoni
pkp#10823 Added possibly missing argument
5e782c4
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 20, 2025
@jonasraoni
pkp#10823 Standardized remaining calls
e245848
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 20, 2025
@jonasraoni
pkp#10823 Fixed notice warning
da5da81
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 20, 2025
@jonasraoni
pkp/pkp-lib#10823 Standardized PKPRouter::initialize() call
309372e
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 20, 2025
@jonasraoni
pkp/pkp-lib#10823 Updated UI locales
dda5950
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 20, 2025
@jonasraoni
pkp/pkp-lib#10823 Submodule Update ##jonasraoni/bugfix-main-10823-sta…
8498a73 
…ndardize-pkprouter-initialization##
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jan 20, 2025
@jonasraoni
pkp/pkp-lib#10823 Standardized PKPRouter::initialize() call
37db9c8
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jan 20, 2025
@jonasraoni
pkp/pkp-lib#10823 Updated UI locales
689a0c6
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jan 20, 2025
@jonasraoni
pkp/pkp-lib#10823 Submodule Update ##jonasraoni/bugfix-main-10823-sta…
1c690c8 
…ndardize-pkprouter-initialization##
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5 Internal
1 participant
@jonasraoni