Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect loop when accessing the site index page #10816

Closed
jonasraoni opened this issue Jan 17, 2025 · 2 comments · Fixed by #10817 or pkp/ojs#4610
Closed

Redirect loop when accessing the site index page #10816

jonasraoni opened this issue Jan 17, 2025 · 2 comments · Fixed by #10817 or pkp/ojs#4610
Assignees
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Milestone

Comments

@jonasraoni
Copy link
Contributor

Describe the bug
After creating two contexts and accessing the main site page, a redirect loop happens.

Looks like an old bug that came to life after updates done at #10670

To Reproduce

  1. Create two contexts
  2. Access the site index

What application are you using?
OJS 3.5/main

@jonasraoni jonasraoni added the Bug:3:Critical A bug that prevents a substantial minority of users from using the software. label Jan 17, 2025
@jonasraoni jonasraoni added this to the 3.5 Internal milestone Jan 17, 2025
@jonasraoni jonasraoni self-assigned this Jan 17, 2025
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 17, 2025
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 17, 2025
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 17, 2025
@jonasraoni jonasraoni linked a pull request Jan 17, 2025 that will close this issue
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 17, 2025
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 17, 2025
@Tribunal33
Copy link

Tribunal33 commented Jan 17, 2025

Adding some details @jonasraoni
I am not clear on how a typical user would access this page? Do you know how to access this without changing the URL?

Prereqs : You will need to have at least 2 contexts (Journals, press or server). Although a single journal can see the redirect for the route but it does correctly land on a page.

Steps

  1. Open the dev tools network tab if you want to watch all the redirect attempts
  2. Go to this route : /index.php/index

Expected: It shoud list out all of the contexts (aka Journals) - Example : https://ojs34.demo.publicknowledgeproject.org/index.php/index/
Actual: There is a redirect loop and eventually an error page
Image

When trying this on a 3.4 page there are no redirects and it boots up with 200 status

Image

Image

@jonasraoni jonasraoni linked a pull request Jan 17, 2025 that will close this issue
jonasraoni added a commit to pkp/ojs that referenced this issue Jan 18, 2025
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jan 18, 2025
@Tribunal33
Copy link

Passes QA on OJS/OMP 3.5. I added some testing around home page (site-wide context) in my QA documents space to cover these base route bugs. I'm now seeing a listing of the journals when more than one journal is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:3:Critical A bug that prevents a substantial minority of users from using the software.
Projects
None yet
2 participants