Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewers block always visible on editorial masthead even when no reviewers exist #10716

Closed
NateWr opened this issue Dec 16, 2024 · 2 comments
Closed

Comments

@NateWr
Copy link
Contributor

NateWr commented Dec 16, 2024

Describe the bug
On the new Editorial Masthead page in the main branch (3.5 pre-release), the "Peer Reviewers" heading and description is shown, even if no reviewers exist.

To Reproduce
Steps to reproduce the behavior:

  1. Load a test instance using the appropriate dataset for main
  2. Go to the Editorial Masthead page on the reader-facing frontend.
  3. See error

What application are you using?
main branch (3.5 pre-release)

NateWr added a commit to NateWr/pkp-lib that referenced this issue Dec 16, 2024
@NateWr
Copy link
Contributor Author

NateWr commented Dec 16, 2024

This happened because a LazyCollection is passed to the template, which always returns true in a if (!empty($reviewers)).

PR:
#10717

Tests:
pkp/ojs#4559

bozana added a commit that referenced this issue Dec 16, 2024
#10716 Fix reviewers block shown when no reviewers exist
@bozana
Copy link
Collaborator

bozana commented Dec 16, 2024

Thanks a lot @NateWr! Merged...

@bozana bozana closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants