Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploaded image is not saved when creating an announcement #10668

Closed
kaitlinnewson opened this issue Dec 9, 2024 · 2 comments
Closed

Uploaded image is not saved when creating an announcement #10668

kaitlinnewson opened this issue Dec 9, 2024 · 2 comments
Assignees
@touhidurabir
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.5 Internal

Comments

@kaitlinnewson
Copy link
Member

kaitlinnewson commented Dec 9, 2024 •
edited by touhidurabir
Loading

Describe the bug
When creating an announcement and uploading an image, the image is not being saved and the following warning is output:

[Mon Dec  9 10:07:30 2024] PHP Warning:  Undefined property: stdClass::$temporaryFileId in /Users/kaitlinnewson/Code/ojs-main/lib/pkp/classes/announcement/Announcement.php on line 120

To Reproduce
Steps to reproduce the behavior:

  1. Enable announcements in the journal (Settings > Website > Setup > Announcements)
  2. Create a new announcement and upload an image with it
  3. See the error, and note that the image is not saved to the announcement.

What application are you using?
OJS, OMP or OPS main (tested in OJS)

PRs
pkp-lib --> #10787
ojs --> pkp/ojs#4591 [TEST ONLY]
@kaitlinnewson kaitlinnewson added this to the 3.5 Internal milestone Dec 9, 2024
@kaitlinnewson kaitlinnewson added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Dec 9, 2024
@NateWr
Copy link
Contributor

NateWr commented Dec 13, 2024

Confirmed. I found it worked for some images but not others. Attaching an example image that did not work.

Even when the upload appeared to work, and I can see the image in my public files directory, the image does not appear in the form when I try to edit the announcement.

Image

@touhidurabir touhidurabir self-assigned this Jan 9, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 9, 2025
@touhidurabir
pkp#10668 Announcement image handling fixed
2bd0920
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 9, 2025
@touhidurabir
pkp/pkp-lib#10668 Submodule Update ##touhidurabir/i10668_main##
6aecdb8
This was referenced Jan 9, 2025
Merged
Closed
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 21, 2025
@touhidurabir
pkp#10668 code cleanup
3bdca93
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 21, 2025
@touhidurabir
pkp#10668 Announcement image handling fixed
0b2ca57
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 21, 2025
@touhidurabir
pkp#10668 code cleanup
69319c0
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 21, 2025
@touhidurabir
pkp/pkp-lib#10668 Submodule Update ##touhidurabir/i10668_main##
2bd99c9
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 21, 2025
@touhidurabir
pkp/pkp-lib#10668 Submodule Update ##touhidurabir/i10668_main##
827abee
touhidurabir added a commit that referenced this issue Jan 23, 2025
@touhidurabir
Merge pull request #10787 from touhidurabir/i10668_main
fdd66d9 
#10668 Announcement image handling fixed
@touhidurabir
Copy link
Member

fixed by #10787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
3 participants
@NateWr @touhidurabir @kaitlinnewson