Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a notification title in the task list does not redirect to the url #10495

Closed
kaitlinnewson opened this issue Oct 2, 2024 · 5 comments
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@kaitlinnewson
Copy link
Member

kaitlinnewson commented Oct 2, 2024

Describe the bug
In a user's notifications tasks list, clicking the title of the notification is not redirecting to the correct url related to that notification

To Reproduce
Steps to reproduce the behavior:

  1. Login as a user that has task notifications (e.g "dbarnes")
  2. Open the tasks list in the upper right corner
  3. Click the title of a notification
  4. See that it is marked as read, but does not redirect to the appropriate url

What application are you using?
OJS, OMP or OPS main

PRs:

@kaitlinnewson kaitlinnewson added this to the 3.5 Internal milestone Oct 2, 2024
@kaitlinnewson kaitlinnewson added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Oct 3, 2024
@kaitlinnewson kaitlinnewson self-assigned this Nov 11, 2024
@kaitlinnewson
Copy link
Member Author

kaitlinnewson commented Nov 11, 2024

I've resolved some errors on the PHP side (PR above), but there is still an issue with the redirect event on the JS side of things.

It seems related to changes made in the redirectRequested event handling - when clicking on the notification link, it does not reach the siteHandler where the redirect would take place in redirectToUrl. I noticed the redirect worked when commenting out this line in AjaxModalWrapper.vue:

https://github.com/pkp/ui-library/blob/a0ab8c6ea9394b58a0afdd20bea03cc0a4058664/src/components/Modal/AjaxModalWrapper.vue#L135

@jardakotesovec any suggestions for the best approach here?

kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Nov 12, 2024
kaitlinnewson added a commit that referenced this issue Nov 13, 2024
@jardakotesovec
Copy link
Contributor

@kaitlinnewson yeah I noticed this issue as well, thanks for filling it... hopefully will get to it sometime soon.

@Tribunal33 Tribunal33 marked this as a duplicate of #10702 Dec 13, 2024
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Dec 16, 2024
jardakotesovec added a commit to pkp/ui-library that referenced this issue Dec 16, 2024
@jardakotesovec
Copy link
Contributor

jardakotesovec commented Dec 16, 2024

@kaitlinnewson Good observations - we have now good compatibility layers for legacy modals with 3.5 (instead of 'manual' opening of that modal) - so basically just leveraged that and that seems to fix the problem.

@Tribunal33 Should be addressed on main. Can you give it a try? Thank you!

kaitlinnewson added a commit to kaitlinnewson/pkp-lib that referenced this issue Dec 16, 2024
@Tribunal33
Copy link

Both bell icon displays list of alert notifications and the links within the alerts page are functioning when selecting them. I would say that they are redirecting to old submission workflows, but I think it is out of scope for this particular ticket. @jardakotesovec what do you think can we close this? I checked OMP and OJS alert bell.

@jardakotesovec
Copy link
Contributor

@Tribunal33 Oki, I added note to #10670 make sure I don't forget it when I get to the redirects and having correct links within apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

3 participants