-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking a notification title in the task list does not redirect to the url #10495
Comments
I've resolved some errors on the PHP side (PR above), but there is still an issue with the redirect event on the JS side of things. It seems related to changes made in the @jardakotesovec any suggestions for the best approach here? |
@kaitlinnewson yeah I noticed this issue as well, thanks for filling it... hopefully will get to it sometime soon. |
…ich correctly handles the events
…ich correctly handles the events
@kaitlinnewson Good observations - we have now good compatibility layers for legacy modals with 3.5 (instead of 'manual' opening of that modal) - so basically just leveraged that and that seems to fix the problem. @Tribunal33 Should be addressed on main. Can you give it a try? Thank you! |
Both bell icon displays list of alert notifications and the links within the alerts page are functioning when selecting them. I would say that they are redirecting to old submission workflows, but I think it is out of scope for this particular ticket. @jardakotesovec what do you think can we close this? I checked OMP and OJS alert bell. |
@Tribunal33 Oki, I added note to #10670 make sure I don't forget it when I get to the redirects and having correct links within apps. |
Describe the bug
In a user's notifications tasks list, clicking the title of the notification is not redirecting to the correct url related to that notification
To Reproduce
Steps to reproduce the behavior:
What application are you using?
OJS, OMP or OPS main
PRs:
The text was updated successfully, but these errors were encountered: