Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal error trying to update own password from Users & Roles section . #10065

Closed
touhidurabir opened this issue Jun 16, 2024 · 1 comment
Closed
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Jun 16, 2024

Describe the bug
Regression introduced with the merge of #9566 which throws fatal error when trying on update own passowrd from the Users & Roles section .

To Reproduce
Steps to reproduce the behavior:

  1. Login in and visit the section Users & Roles under the Settings section
  2. From the Users list , click on Edit User of the user as who current user is logged in
  3. In the edit form, update password.
  4. Save and see that edit form does not close itself and the spinner the going on.

What application are you using?
OJS, OMP or OPS version main(upcoming 3.5)

Additional information
Full error trace as following

[15-Jun-2024 20:37:39 UTC] PHP Fatal error:  Uncaught InvalidArgumentException: The given password does not match the current password. in /Users/abir/Sites/code/ojs-main/lib/pkp/classes/core/PKPSessionGuard.php:279
Stack trace:
#0 /Users/abir/Sites/code/ojs-main/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Auth/SessionGuard.php(670): PKP\core\PKPSessionGuard->rehashUserPassword('123456', 'password')
#1 /Users/abir/Sites/code/ojs-main/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php(340): Illuminate\Auth\SessionGuard->logoutOtherDevices('123456')
#2 /Users/abir/Sites/code/ojs-main/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(353): Illuminate\Auth\AuthManager->__call('logoutOtherDevi...', Array)
#3 /Users/abir/Sites/code/ojs-main/lib/pkp/controllers/grid/settings/user/form/UserDetailsForm.php(353): Illuminate\Support\Facades\Facade::__callStatic('logoutOtherDevi...', Array)
#4 /Users/abir/Sites/code/ojs-main/lib/pkp/controllers/grid/settings/user/UserGridHandler.php(401): PKP\controllers\grid\settings\user\form\UserDetailsForm->execute()
#5 [internal function]: PKP\controllers\grid\settings\user\UserGridHandler->updateUser(Array, Object(APP\core\Request))
#6 /Users/abir/Sites/code/ojs-main/lib/pkp/classes/core/PKPRouter.php(346): call_user_func(Array, Array, Object(APP\core\Request))
#7 /Users/abir/Sites/code/ojs-main/lib/pkp/classes/core/PKPComponentRouter.php(293): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(APP\core\Request), Array)
#8 /Users/abir/Sites/code/ojs-main/lib/pkp/classes/core/Dispatcher.php(171): PKP\core\PKPComponentRouter->route(Object(APP\core\Request))
#9 /Users/abir/Sites/code/ojs-main/lib/pkp/classes/core/PKPApplication.php(379): PKP\core\Dispatcher->dispatch(Object(APP\core\Request))
#10 /Users/abir/Sites/code/ojs-main/index.php(21): PKP\core\PKPApplication->execute()
#11 /Users/abir/.composer/vendor/laravel/valet/server.php(235): require('/Users/abir/Sit...')
#12 {main}
  thrown in /Users/abir/Sites/code/ojs-main/lib/pkp/classes/core/PKPSessionGuard.php on line 279

PRs
pkp-lib --> #10066
ojs --> pkp/ojs#4320 [TEST ONLY]

pkp-lib --> pkp-lib [rehash issue]
ojs --> pkp/ojs#4327 [TEST ONLY]

@touhidurabir touhidurabir added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jun 16, 2024
@touhidurabir touhidurabir added this to the 3.5 Internal milestone Jun 16, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 16, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 16, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jun 16, 2024
touhidurabir added a commit that referenced this issue Jun 16, 2024
#10065 fixed issue of updating own password form users & roles section
@touhidurabir
Copy link
Member Author

fixed by #10066 .

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jun 19, 2024
@touhidurabir touhidurabir reopened this Jun 19, 2024
touhidurabir added a commit that referenced this issue Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

2 participants