From 0e77fdcc9e0190b57cf7000189ff4e555ee10dd7 Mon Sep 17 00:00:00 2001 From: Jacob Heider Date: Mon, 7 Oct 2024 18:34:56 -0400 Subject: [PATCH] fix(mvfst) closes #7558 --- projects/facebook.com/mvfst/package.yml | 29 ++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/projects/facebook.com/mvfst/package.yml b/projects/facebook.com/mvfst/package.yml index 8ccb8e46d2..50e7864806 100644 --- a/projects/facebook.com/mvfst/package.yml +++ b/projects/facebook.com/mvfst/package.yml @@ -28,6 +28,33 @@ build: # llvm's `as` likes to be first, wrongly - run: export PATH={{deps.gnu.org/binutils.prefix}}/bin:$PATH if: linux + # fix missing symbols + - run: patch -p1 <$PROP + prop: | + diff --git a/quic/api/CMakeLists.txt b/quic/api/CMakeLists.txt + index 5522347c5..a0a34761e 100644 + --- a/quic/api/CMakeLists.txt + +++ b/quic/api/CMakeLists.txt + @@ -47,6 +47,7 @@ add_library( + QuicPacketScheduler.cpp + QuicStreamAsyncTransport.cpp + QuicTransportBase.cpp + + QuicTransportBaseLite.cpp + QuicTransportFunctions.cpp + ) + + diff --git a/quic/state/CMakeLists.txt b/quic/state/CMakeLists.txt + index 0916546fe..14297bb30 100644 + --- a/quic/state/CMakeLists.txt + +++ b/quic/state/CMakeLists.txt + @@ -55,6 +55,7 @@ add_library( + mvfst_state_ack_handler + AckEvent.cpp + AckHandlers.cpp + + AckedPacketIterator.cpp + ) + + set_property(TARGET mvfst_state_ack_handler PROPERTY VERSION ${PACKAGE_VERSION}) - cmake -S . -B _build $CMAKE_ARGS - cmake --build _build - cmake --install _build @@ -97,7 +124,7 @@ test: target_link_libraries(echo ${mvfst_LIBRARIES} fizz::fizz_test_support GTest::gmock) target_include_directories(echo PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}) - - cmake . $ARGS + - cmake . - cmake --build . # SUPER FIXME: the original test wasn't working at all, so this is progress rather than a regression