Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: The event listening area for drag events should be the slider instead of the background #136

Closed
hotyes opened this issue Feb 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@hotyes
Copy link

hotyes commented Feb 29, 2024

Please Describe The Problem To Be Solved
The current event listener are adding on the bg instead of the slider, which is counterintuitive.

Sometimes we also want to design the background of the slider as a thin line, but the slider is larger. In the current behavior, it is not easy for the user to drag the slider.

image

(Optional): Suggest A Solution

Add event listeners to "slider" instead of "bg", or to both.

@hotyes hotyes added the enhancement New feature or request label Feb 29, 2024
@CyberDex
Copy link
Member

Fixed in #137

@hotyes
Copy link
Author

hotyes commented Mar 27, 2024

hi @CyberDex is this fixed in v1.0.0? I just tried but seems still the same

@hotyes
Copy link
Author

hotyes commented May 1, 2024

PR #137 does not resolve this issue and remains in v1 and v2

@CatchABus
Copy link
Contributor

CatchABus commented Jul 6, 2024

The PR that references the issue seems to be fixing most of the problems except for sliding outside of bounds.

image

What I circled above is non-interactive and it's hard for users to move the slider unless they drag the other half.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants