Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Improve linter coverage #712

Open
6 tasks
jonathan-j-lee opened this issue Oct 3, 2019 · 0 comments
Open
6 tasks

Improve linter coverage #712

jonathan-j-lee opened this issue Oct 3, 2019 · 0 comments

Comments

@jonathan-j-lee
Copy link
Member

jonathan-j-lee commented Oct 3, 2019

Is your feature request related to a problem? Please describe.
Over time, we've used pylint: disable to disable too many warnings. Also, the version of pylint we use for Runtime is very out-of-date, meaning there are potentially code style best practices that are not enforced.

Describe the solution you'd like

  • Upgrade pylint version in Pipfile
  • Eliminate disabled warnings ansible.py
  • Eliminate disabled warnings runtime.py
  • Eliminate disabled warnings runtimeUtil.py
  • Eliminate disabled warnings in studentapi.py
  • Eliminate disabled warnings in statemanager.py

When you run make lint from runtime, no errors should be reported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants