Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when only some node hasn't sync, DDL owner always print 'syncer check all versions, all nodes are not synced' #58480

Closed
D3Hunter opened this issue Dec 23, 2024 · 0 comments · Fixed by #58511
Closed

when only some node hasn't sync, DDL owner always print 'syncer check all versions, all nodes are not synced' #58480

D3Hunter opened this issue Dec 23, 2024 · 0 comments · Fixed by #58511
Assignees
@D3Hunter
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

because in here, we return false directly on length mismatch, so we don't know who is unmatched

tidb/pkg/ddl/schemaver/syncer.go

Lines 375 to 377 in 042a332

if len(nodeVersions) < len(updatedMap) {
return false
}

and cause this always enter the else branch

tidb/pkg/ddl/schemaver/syncer.go

Lines 397 to 406 in 042a332

if id := unmatchedNodeID.Load(); id != nil {
logutil.DDLLogger().Info("syncer check all versions, someone is not synced",
zap.String("info", *id),
zap.Int64("ddl job id", jobID),
zap.Int64("ver", latestVer))
} else {
logutil.DDLLogger().Info("syncer check all versions, all nodes are not synced",
zap.Int64("ddl job id", jobID),
zap.Int64("ver", latestVer))
}

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master
@D3Hunter D3Hunter added affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug. labels Dec 23, 2024
@D3Hunter D3Hunter changed the title we only some node hasn't sync, DDL owner always print 'syncer check all versions, all nodes are not synced' when only some node hasn't sync, DDL owner always print 'syncer check all versions, all nodes are not synced' Dec 23, 2024
@D3Hunter D3Hunter self-assigned this Dec 23, 2024
@jebter jebter added the component/ddl This issue is related to DDL of TiDB. label Dec 24, 2024
@D3Hunter D3Hunter mentioned this issue Dec 24, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 623191c Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@D3Hunter D3Hunter

Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: fix version syncer doesn't print who hasn't synced on partial sync D3Hunter/tidb
2 participants
@D3Hunter @jebter