Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration missing on 3.3.1 #374

Closed
carchan1 opened this issue Sep 12, 2023 · 4 comments · Fixed by #375
Closed

Migration missing on 3.3.1 #374

carchan1 opened this issue Sep 12, 2023 · 4 comments · Fixed by #375
Labels

Comments

@carchan1
Copy link

carchan1 commented Sep 12, 2023

Describe the bug
There is a migration missing on django-user-accounts side for version 3.3.1

Reproduce behavior
Run

python manage.py makemigration

Results:

Migrations for 'account':
  C:\my_project\venv\lib\site-packages\account\migrations\0009_alter_signupcode_max_uses.py
    - Alter field max_uses on signupcode

Expected behavior
I expect that django-user-accounts comes with all its migrations

@carchan1 carchan1 added the Bug label Sep 12, 2023
@carchan1 carchan1 changed the title Migration mission on 3.3.1 Migration missing on 3.3.1 Sep 12, 2023
@uhurusurfa
Copy link
Collaborator

Something is not right - the app only has files up to prefix 0005 so not sure where your 0009 prefix file comes from.
Did you use a fork of this app previously?

@carchan1
Copy link
Author

@uhurusurfa No, it's just that I played a bit with my DB and ran makemigrations few times 🙃
image

@taialex1
Copy link

It seems this commit is missing a migration for the change of the default value.

@blag
Copy link
Collaborator

blag commented Sep 12, 2023

Possibly fixed in #375.

Perhaps we should include some CI checks that use makemigrations to ensure migrations are included in PRs.

And another one to ensure that all required files are included in wheels and sdists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants