refactor: Namespace config options using dot notation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, will take a look today! |
Great, thank you! Let me know if you have any questions or if there's anything else I can do to help. |
|
Hey we have changed our environment variables recently, and this PR is not relevance for now. Thank you for your contributions though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive update to the configuration options in the CLI package. With this update, all options have been namespaced using dot notation, making it much easier to manage and organize them. This change results in cleaner and more readable code, which will be especially beneficial as the number of configuration options continues to grow.
All configuration options, including those related to Loki and the signer, have been updated to use the dot notation format. This change also involved updating all references to these configuration options throughout the package.
The code has been thoroughly tested to ensure that the new configuration options are properly implemented and function as expected. The tests have been included in the pull request for review.
Overall, this update will make it much easier for developers to work with and maintain the configuration options in the CLI package, leading to more efficient and streamlined development processes.
closes #15