Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss API #1

Open
Fishrock123 opened this issue Jan 30, 2016 · 2 comments
Open

discuss API #1

Fishrock123 opened this issue Jan 30, 2016 · 2 comments
Labels

Comments

@Fishrock123
Copy link
Member

@dougwilson I dunno if you also worked on this, but I cleaned up the work I did ages ago and published it so we can discuss it. :P

I like working with prototype silliness so I don't mind maintaining this some.

@dougwilson
Copy link

Hey @Fishrock123, I'm trying to catch up to all these issues, and just wanted to drop by here with one initial concerns I have with this module: it does not seem to have the same Node.js version support policy as the other pllarjs modules: Node.js 0.8+. This policy can certainly be discussed on what to bump to, but just wanted to throw that out there, as it is something that is a concern when adding any dependency to Express on what versions the module supports. I don't see any reason why at least Node.js 0.10 can't be supported by this module?

@dougwilson
Copy link

So looking at this module, I remember one of the key features we wanted in the module was for help with getting to http2 support, but it doesn't seem possible with this module, since this will still keep the prototype tied to a base? I was imaging something that would actually literally take a given object with a prototype chain and break one of the bonds to add a new object into that chain. Certainly at that point the name extend-proto doesn't really make sense, though, so perhaps a new module for Express to use to get to our goals?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants