Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/improve temporal filtering #17

Open
tsalo opened this issue Jun 17, 2020 · 3 comments
Open

Update/improve temporal filtering #17

tsalo opened this issue Jun 17, 2020 · 3 comments

Comments

@tsalo
Copy link
Member

tsalo commented Jun 17, 2020

Currently, I believe that there are hardcoded cutoffs for different modalities, but we probably want to be able to calculate cutoffs from sequence parameters as well. @62442katieb, I think this is your area of expertise.

@rmarkello
Copy link
Member

I don't believe those modalities actually do anything right—I think they're vestiges from a former iteration of the codebase. I kept them as a reference for myself for what cutoffs were reasonable (though, as you accurately note, that will depend on sampling frequency!).

They could definitely be improved to actually do stuff, though!! 💯

@62442katieb
Copy link

I haven't familiarized myself with the codebase yet, but once I do, I'm definitely interested in looking through and adding/tweaking some filtering based on what I've been learning the past couple months!

+1 for actually doing stuff! 😄

@rmarkello
Copy link
Member

The ReadTheDocs site is still live! Though I don't think any new changes will get pushed to that since it was hosted from my user account and not the physiopy org (I don't know how RTD handles ownership transfers 🤷‍♂️).

Anyway, happy to help people orient themselves to peakdet! I won't be contributing anything new anytime soon (see: for the remainder of grad school 😅) but am happy to answer questions.

@m-miedema m-miedema transferred this issue from physiopy/peakdet Jul 25, 2024
@tsalo tsalo removed their assignment Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants