Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the MRIConfig and Physio classes #5

Open
maestroque opened this issue Aug 19, 2024 · 4 comments
Open

Integrate the MRIConfig and Physio classes #5

maestroque opened this issue Aug 19, 2024 · 4 comments

Comments

@maestroque
Copy link
Contributor

Goal

The main scope of the MRIConfig class is to contain all the relevant information about the MRI scan, that are useful in the following steps of the data processing workflow. These are currently stemming from phys2denoise functions, namely slice_timings, n_scans and tr and are used in metrics computations. Integrating a structure containing those into the Physio object would greatly facilitate the relevant workflow.

Implementation

The acquisition of those parameters could be:

  • Manually given by the user
  • Automatically detected from the trigger channel of a physio recording.

Especially in case this is done through the load_from_bids function, the trigger channel would be automatically used as a source of acquisition, unless specified against.

Then, the load_from_bids function should output an object containing the array of Physio objects, and an MRIConfig class. This could be the aforementioned multimodal Physio class.

@maestroque
Copy link
Contributor Author

@smoia @m-miedema @me-pic I think I should prioritize the p2d workflow and then if time allows implement this. Wdyt?

@me-pic
Copy link
Contributor

me-pic commented Aug 19, 2024

Sounds reasonable to me !

@m-miedema
Copy link
Member

Yes, definitely!

@m-miedema
Copy link
Member

I want to link my comment here since it's relevant to the goals of this issue.

@maestroque maestroque removed their assignment Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants