Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in physioqc.interfaces.interfaces.run metrics() #10

Open
celprov opened this issue Jul 21, 2023 · 1 comment
Open

Problem in physioqc.interfaces.interfaces.run metrics() #10

celprov opened this issue Jul 21, 2023 · 1 comment
Labels
Bug Something isn't working

Comments

@celprov
Copy link
Collaborator

celprov commented Jul 21, 2023

Stuff that needs to be addressed after the code developed for OHBM23.

If the function m is peak_amplitude or peak_distance, you should first run peak_detection and then pass the output of peak_detection to the latter.

@celprov celprov added the Bug Something isn't working label Jul 21, 2023
@SRSteinkamp
Copy link
Collaborator

Alternatively, just run peak_detection at the beginning, while that means that peaks and troughs will also be plotted on the raw-data plot, which I think is fine (I could also implement something to suppress it), peak_amplitude / peak_distance will work without further adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: To Do
Development

No branches or pull requests

2 participants