Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Major: Make classes final where possible #317

Closed
dbu opened this issue Mar 4, 2019 · 3 comments
Closed

Next Major: Make classes final where possible #317

dbu opened this issue Mar 4, 2019 · 3 comments
Milestone

Comments

@dbu
Copy link
Collaborator

dbu commented Mar 4, 2019

Q A
Bug? no
New Feature? no
Version BC breaking change: Next major

Classes like the factories are not final. We should go over the bundle and make everything final that is not explicitly intended to be extended. Also check for things with protected visibility and make them private where possible.

@dbu dbu added this to the 2.0.0 milestone Mar 4, 2019
@xabbuh
Copy link
Member

xabbuh commented Mar 4, 2019

For one of the next 1.x releases we can already flag these classes with the @final annotation in the class docblock. The DebugClassLoader from the Symfony Debug component will then raise a deprecation if someone extends these final classes without a hard break.

@andrew-demb
Copy link
Contributor

Since there's no final decision from the @php-http/owners on the discussion #321 (comment) - should this issue be considered to be a blocker for 2.0.0?

@dbu

@xabbuh
Copy link
Member

xabbuh commented Sep 6, 2024

fixed in #467

@xabbuh xabbuh closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants