Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During plugin install: Don't globally deactive a package which was activated before #172

Open
passsy opened this issue Jan 10, 2023 · 0 comments
Labels
enhancement New feature or request plugins All plugin related issues

Comments

@passsy
Copy link
Contributor

passsy commented Jan 10, 2023

This is a rare use-case but technically possible and easy to fix.

Given package_a is globally installed.

When installing <cli> packages install package_a the package is afterwards deactivated.

// TODO Don't deactivate when the package was already activated
// The package was only activated to cache it and can be deactivated now

// TODO Maybe we should do a `dart pub global list` first to check if
// the package is already activated. If it is already activated,
// we should at least print a warning because we are altering the
// user's environment in a possibly unexpected way by calling
// `dart pub global activate/deactivate`.

@passsy passsy added enhancement New feature or request plugins All plugin related issues labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugins All plugin related issues
Projects
None yet
Development

No branches or pull requests

1 participant