Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker Twig Function #137

Closed
jryanconklin opened this issue Oct 23, 2017 · 2 comments
Closed

Add Faker Twig Function #137

jryanconklin opened this issue Oct 23, 2017 · 2 comments

Comments

@jryanconklin
Copy link
Contributor

jryanconklin commented Oct 23, 2017

See Issue on php twig edition for bones of Twig function using Faker. Adapting this would use of Faker within Twig as:

{{ faker('property', 'options' }}

This is likely impacted by the issues currently in pattern-lab/plugin-php-faker. For example, when working with this as {{ faker('ImageUrl', 200, 200) }}, only the first argument is honored, returning: https://lorempixel.com/200/480/?57256. Note there is an open PR for plugin issue #4

@illepic
Copy link
Contributor

illepic commented Oct 8, 2018

@jryanconklin do we want to leave this open?

@jryanconklin
Copy link
Contributor Author

No, let’s go ahead and close it.

@illepic illepic closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants