You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the latests commits had to include a "hack" to update the desiredVisibleRow in a Spec tree presenter. The problem was discovered after expanding the path selection and scrolling to the selected item was not scrolling. But after debugging, it was actually scrolled, and another deferred action set back the idex to 1.
This happened because the Morphic configureScrolling is executed AFTER without an update to the new selected row index. Furthermore, the configureScrolling uses the desiredVisibleRow which is always set to 1.
The fix was to updates (manually) the desired visible row to the last visible index of whatever the selection is pointing to. But this probably should be done by Spec by default when the selected item is configured and scrolling is set to true.
Please let me know if this should be moved as Spec issue.
The text was updated successfully, but these errors were encountered:
One of the latests commits had to include a "hack" to update the
desiredVisibleRow
in a Spec tree presenter. The problem was discovered after expanding the path selection and scrolling to the selected item was not scrolling. But after debugging, it was actually scrolled, and another deferred action set back the idex to 1.This happened because the Morphic
configureScrolling
is executed AFTER without an update to the new selected row index. Furthermore, theconfigureScrolling
uses thedesiredVisibleRow
which is always set to 1.The fix was to updates (manually) the desired visible row to the last visible index of whatever the selection is pointing to. But this probably should be done by Spec by default when the selected item is configured and scrolling is set to true.
Please let me know if this should be moved as Spec issue.
The text was updated successfully, but these errors were encountered: