Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated logic for showing the shortcuts #765

Open
jordanmontt opened this issue May 31, 2024 · 0 comments
Open

Duplicated logic for showing the shortcuts #765

jordanmontt opened this issue May 31, 2024 · 0 comments

Comments

@jordanmontt
Copy link
Contributor

The text shown for the shortcuts, this one:

Sans titre

Is defined in this method through the keyText: message. Like this:

menuCommandOn: aBuilder
	<worldMenu>
	(aBuilder item: #Playground)
		parent: #InputOutput;
		action: [ Smalltalk tools openWorkspace ];
		order: 1;
		keyText: 'o, p';
		help: 'A window used as a scratchpad area where fragments of Pharo code can be entered, stored, edited, and evaluated.';
		iconName: #workspace

But, the shortcuts themselves are defined here:

PharoShortcuts >> openPlaygroundShortcut
	^ $o meta, $p meta

This causes duplicated logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant