Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FFIExternalValueHolder in bindings #17

Open
tinchodias opened this issue Oct 25, 2022 · 2 comments
Open

Use FFIExternalValueHolder in bindings #17

tinchodias opened this issue Oct 25, 2022 · 2 comments

Comments

@tinchodias
Copy link
Contributor

IIUC from Pablo, it is more correct to create the object to pass as pointer to FFI in this way:

Screen Shot 2022-10-25 at 19 25 35

BUT, saving in some global way e.g. FFIExternalValueHolder ofType: 'void*'.
The class FT2Types would be an example.
@tinchodias
Copy link
Contributor Author

Maybe LGitWriteBackValueInt is good as example, too.

@tinchodias
Copy link
Contributor Author

Note:
The diff above implies this other change in the FFI signature:

Screen Shot 2022-10-25 at 19 51 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tinchodias