Supersede derive_var_bcvacritxfl() and update vignettes/templates that use it
#247
Assignees
Comments
manciniedoardo
changed the title
derive_var_bcvacritxfl() and update vginettes/templates that use it
manciniedoardo
changed the title
derive_var_bcvacritxfl() and update vginettes/templates that use itderive_var_bcvacritxfl() and update vignettes/templates that use it
steventing12
added a commit
that referenced
this issue
Oct 21, 2024
…placing look-up table with derive_vars_merged() feat: #247 Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
|
Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl() |
|
Can you please make a pull request with your proposed changes? That way I can review code/changes and propose amendments. |
This was referenced Oct 22, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background Information
With the advent of admiral::derive_vars_crit_flag() there is less of a need for
admiralophtha::derive_var_bcvacrtixfl(). The latter should be superseded, in line with the {admiral} family's policy to not make many breaking changes post 1.0 releases.Definition of Done
derive_var_bcvacritxfl()superseded. See here for an example of a superseded function from {admiral}.derive_vars_crit_flag(), possibly in conjunction withcall_derivation().The text was updated successfully, but these errors were encountered: