Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary download fails if previous download attempt fails #43

Open
danieltharp opened this issue Mar 23, 2024 · 0 comments
Open

Binary download fails if previous download attempt fails #43

danieltharp opened this issue Mar 23, 2024 · 0 comments

Comments

@danieltharp
Copy link

Maybe a little quality of life enhancement to consider.

I was going through initial setup on a new Mac and ran a test makelove build and because I'd forgotten to install the certifi package from pip, the download failed. However, makelove had made the folder in /Users/{user}/Library/Caches/makelove/love-binaries/{version}/macos. When I fixed the issue and reran, it assumed the file was in there even though the directory was empty. It may be worth checking for the actual binary rather than the simple existence of the folder. I can probably submit a PR for this if it would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant