Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.5 AppImages don't work #42

Open
tinydanbo opened this issue Feb 16, 2024 · 4 comments
Open

11.5 AppImages don't work #42

tinydanbo opened this issue Feb 16, 2024 · 4 comments

Comments

@tinydanbo
Copy link

Generating AppImages for LOVE 11.5 doesn't work.

The reason for this appears to be that makelove fuses the .love file to the bin/love binary and renames it to bin/{game_name}, like so:

# Official AppImages (since 11.4) -> fuse the .love file to the love binary

However, the AppRun script inside 11.5 appimages is specifically looking for bin/love : https://github.com/love2d/love-appimage-source/blob/a945d735c61c82214f1fa4b803d2cae19432ba22/love.sh#L30

So running a built 11.5 appimage simply results in a "bin/love: No such file or directory" error.

@MikuAuahDark
Copy link

MikuAuahDark commented Feb 18, 2024

There are certain ways to fuse with 11.5 AppImage (for maintainers):

  1. Fuse as you'd do in Windows. Note that you have to change the executable target from bin/love to bin/yourgame.
  2. Put your yourgame.love in share folder (or extract it in share/yourgame directory) then uncomment and change the FUSE_PATH variable to $APPDIR/share/yourgame.love or $APPDIR/share/yourgame.

As for the original AppRun script itself, I think it can be improved by reading the Exec= in the .desktop file. Patches welcome.

I was responsible of managing the AppImage build script and the AppRun was changed inbetween 11.4 and 11.5 from C program to simple shell script. Sorry for the inconvenience.

@gustavostuff
Copy link

gustavostuff commented Mar 5, 2024

@MikuAuahDark thanks! I did point 1 and that was enough to solve the issue.

@kongeor
Copy link

kongeor commented Jun 8, 2024

Hello and thank you for your work on this.

I bumped onto this issue too and while I'm at it, I tried to see if I could patch it.

I'm pretty sure my approach is not good but with some guidance I think it would be nice to fix that.

@ParticleG
Copy link

ParticleG commented Nov 7, 2024

There are certain ways to fuse with 11.5 AppImage (for maintainers):

  1. Fuse as you'd do in Windows. Note that you have to change the executable target from bin/love to bin/yourgame.
  2. Put your yourgame.love in share folder (or extract it in share/yourgame directory) then uncomment and change the FUSE_PATH variable to $APPDIR/share/yourgame.love or $APPDIR/share/yourgame.

As for the original AppRun script itself, I think it can be improved by reading the Exec= in the .desktop file. Patches welcome.

I was responsible of managing the AppImage build script and the AppRun was changed inbetween 11.4 and 11.5 from C program to simple shell script. Sorry for the inconvenience.

This should be updated to Game Distribution wiki. The current wiki version is for 11.4, which would cause a No Game screen when using 11.5 AppImage. I'm using love-actions/love-actions-linux.

c2ca2c8f1879ee79a87e0874c1165a2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants