Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to provide TLS Certificates to Perses #62

Open
dougkirkley opened this issue Feb 5, 2025 · 4 comments · May be fixed by #65
Open

Add the ability to provide TLS Certificates to Perses #62

dougkirkley opened this issue Feb 5, 2025 · 4 comments · May be fixed by #65

Comments

@dougkirkley
Copy link

This needs to allow the ability to add Volumes/VolumeMounts as well as additional flags to pass to perses
@Nexucis
Copy link
Member

Nexucis commented Feb 6, 2025

that's something that should be aligned also with the helm chart.

@dougkirkley
Copy link
Author

@jgbernalp Do you have any thoughts on a client.tlsConfig field at the top level to provide to the Perses client?

@jgbernalp
Copy link
Contributor

I think it could be something like

client:
  tls:
      enable: true
      insecureSkipVerify: false
      caCert:
        type: secret | configmap
        name: client-ca-bundle
        certFile: service-ca.crt
      userCert: // (optional) for use with mTLS
        type: secret | configmap
        name: custom-cert
        certFile: custom.crt
        certKey: custom.key (optional)

caCert and userCert are the same type

@dougkirkley dougkirkley linked a pull request Feb 7, 2025 that will close this issue
Draft
@dougkirkley
Copy link
Author

Added a draft PR in case you had any issues with the design so far. It passed tests but I still need to actually test the image on a cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TLS config to Perses client and mount certs to Deployment and Sta… dougkirkley/perses-operator
3 participants
@Nexucis @jgbernalp @dougkirkley