Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.train() needs a refactor #79

Open
oadams opened this issue Feb 16, 2018 · 5 comments
Open

Model.train() needs a refactor #79

oadams opened this issue Feb 16, 2018 · 5 comments
Labels

Comments

@oadams
Copy link
Collaborator

oadams commented Feb 16, 2018

The stopping criteria and nesting of are getting unwieldy and bugs are likely to creep in. It's also quite long and could be broken down.

@shuttle1987
Copy link
Member

shuttle1987 commented Feb 16, 2018

The train method seems like it's very long and perhaps doing a bit too much in the one method. I'd need some info as to where the code can be split though. For a start I feel like the training and file handling could be in separate methods here.

@shuttle1987
Copy link
Member

I'd be happy to pair program a bit on this one to get this cleaned up, let me know if you are keen.

@oadams
Copy link
Collaborator Author

oadams commented Feb 17, 2018

Sounds good, let's do it.

@shuttle1987
Copy link
Member

I've cleaned this up a bit in #147, specifically I have moved to using context managers for a few things so that handling the closing of files and sessions is easier. It has made the nesting one level deeper in places though, but overall I think it's less complex.

@shuttle1987
Copy link
Member

I feel like when #154 is closed we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants