-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model.train() needs a refactor #79
Comments
The train method seems like it's very long and perhaps doing a bit too much in the one method. I'd need some info as to where the code can be split though. For a start I feel like the training and file handling could be in separate methods here. |
I'd be happy to pair program a bit on this one to get this cleaned up, let me know if you are keen. |
Sounds good, let's do it. |
I've cleaned this up a bit in #147, specifically I have moved to using context managers for a few things so that handling the closing of files and sessions is easier. It has made the nesting one level deeper in places though, but overall I think it's less complex. |
I feel like when #154 is closed we can close this issue. |
The stopping criteria and nesting of are getting unwieldy and bugs are likely to creep in. It's also quite long and could be broken down.
The text was updated successfully, but these errors were encountered: