Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model descriptions serialization #153

Closed
shuttle1987 opened this issue May 26, 2018 · 1 comment
Closed

Model descriptions serialization #153

shuttle1987 opened this issue May 26, 2018 · 1 comment

Comments

@shuttle1987
Copy link
Member

shuttle1987 commented May 26, 2018

Related to #154

As it stands the model descriptions are made in an ad-hoc format:

def write_desc(self):
""" Writes a description of the model to the exp_dir. """
path = os.path.join(self.exp_dir, "model_description.txt")
with open(path, "w") as desc_f:
for key, val in self.__dict__.items():
print("%s=%s" % (key, val), file=desc_f)

I propose that we make this a more easily parseable format when we write this to a file.

I'm thinking something like YAML or JSON works well here. Is there a preference for serialization format?

JSON comes in the standard library but has a bit less flexibility. That said flexibility isn't necessarily a benefit here.

@shuttle1987
Copy link
Member Author

Using Keras will really fix this properly, but I think we have done enough as of the changes in PR #197 to close this issue.

@oadams oadams closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants