Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required parameters incomplete in API spec #110

Open
aapeliv opened this issue Oct 22, 2018 · 2 comments
Open

Required parameters incomplete in API spec #110

aapeliv opened this issue Oct 22, 2018 · 2 comments

Comments

@aapeliv
Copy link
Collaborator

aapeliv commented Oct 22, 2018

The set of required properties should be properly defined.

For instance audioFileInformation doesn't mark id as required.

Or is there some other reason why id is not required in audioFileInformation and other definitions. (audioFileInformation is only used in GETs).
@shuttle1987
Copy link
Member

I think this is fixed now that the PR with the validation fixes #108 was merged in, it would be good if you can confirm this.

@shuttle1987
Copy link
Member

The main issue here is just that I wanted to define objects for use in both uploads and downloads, when uploading the id is not in existence just yet so it's therefore not marked as required. Getting this to work properly with OpenAPI is a bit of a pain though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shuttle1987 @aapeliv