Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for proppatch method #206

Open
masx200 opened this issue May 16, 2020 · 5 comments
Open

Support for proppatch method #206

masx200 opened this issue May 16, 2020 · 5 comments

Comments

@masx200
Copy link

masx200 commented May 16, 2020

Support for proppatch method

https://www.ietf.org/rfc/rfc4918.html#section-9.2

@yoh1496
Copy link

yoh1496 commented May 28, 2020

Hi @masx200 , @perry-mitchell

I implemented 'PROPPATCH' method before.
I'll write some test codes and send PR to this repository.

What kind of test cases are needed ?

@skjnldsv
Copy link
Contributor

skjnldsv commented Oct 7, 2020

@yoh1496 any news? :)

@yoh1496
Copy link

yoh1496 commented Oct 9, 2020

@skjnldsv

Hi, John.
I'm stuck in this issue. #210

For implementing proppatch method, it is needed to implement handling property with namespace in propfind method.

@anatolyukropov
Copy link
Contributor

anatolyukropov commented Dec 7, 2020

@yoh1496 any news ?
Or maybe can someone give me an example of how to write a custom method to setProps to files
I try to do like this:

const propertyupdate = new XMLElementBuilder('D:propertyupdate', {
            'xmlns:D': 'DAV:'
        });
        const prop = propertyupdate.ele('D:set').ele('D:prop');
        for(const name in properties)
            prop.ele(name, properties[name].attributes).add(properties[name].content);
			
		const contents = await client.customRequest("/alrighty.jpg", {
			method: "PROPPATCH",
	        data: propertyupdate.toXML(),
		});

but got 400 error

@yoh1496
Copy link

yoh1496 commented Dec 15, 2020

@anatolyukropov

This is my implementation.
master...yoh1496:feature/proppatch

By using this, you can PROPPATCH like below

this.client.updateProperty(propertyupdatePath, {
      headers: { 'Content-Type': 'application/xml' },
      data: propertyupdateXML,
});

I don't know why your code does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants