Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth-plugin 0.4.1 fails tests with ruby 1.8.7 #127

Open
graaff opened this issue Aug 15, 2012 · 0 comments
Open

oauth-plugin 0.4.1 fails tests with ruby 1.8.7 #127

graaff opened this issue Aug 15, 2012 · 0 comments

Comments

@graaff
Copy link

graaff commented Aug 15, 2012

With ruby 1.8.7 (2012-06-29 patchlevel 370) [x86_64-linux] I'm getting a few test failures. These all looks like innocent manifestations of the now-random hash ordering in newer patch levels of ruby 1.8.7.

  1) OAuth::Provider::Authorizer Authorization code should issue code should include state
     Failure/Error: @authorizer.redirect_uri.should == "http://mysite.com/callback?code=secret%20auth%20code&state=customer%20id"
       expected: "http://mysite.com/callback?code=secret%20auth%20code&state=customer%20id"
            got: "http://mysite.com/callback?state=customer%20id&code=secret%20auth%20code" (using ==)
     # ./spec/oauth/provider/authorizer_spec.rb:49

  2) OAuth::Provider::Authorizer user does not authorize should send error with state and query params in callback
     Failure/Error: @authorizer.redirect_uri.should == "http://mysite.com/callback?this=one&error=access_denied&state=my%20customer"
       expected: "http://mysite.com/callback?this=one&error=access_denied&state=my%20customer"
            got: "http://mysite.com/callback?this=one&state=my%20customer&error=access_denied" (using ==)
     # ./spec/oauth/provider/authorizer_spec.rb:92

  3) OAuth::Provider::Authorizer user does not authorize should send error with state and query params in callback
     Failure/Error: @authorizer.redirect_uri.should == "http://mysite.com/callback?this=one#error=access_denied&state=my%20customer"
       expected: "http://mysite.com/callback?this=one#error=access_denied&state=my%20customer"
            got: "http://mysite.com/callback?this=one#state=my%20customer&error=access_denied" (using ==)
     # ./spec/oauth/provider/authorizer_spec.rb:182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant