Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle disconnecting peers #6

Open
pekam opened this issue May 10, 2019 · 0 comments
Open

Handle disconnecting peers #6

pekam opened this issue May 10, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@pekam
Copy link
Owner

pekam commented May 10, 2019

Currently, the component doesn't do anything with disconnecting peers. This causes following issues:

  • The carets of disconnected users are still rendered.
  • The state vectors contain entries that are no more needed (not a significant memory leak though, as the number of new connections should be relatively small in an editing session).
  • The garbage collector (Garbage collecting the operation log #4) can't remove anything from the log after a user has disconnected, because it expects the disconnected client to integrate the operation before it can be removed.

There are a couple of options for this:

  • Provide API for the users to handle this, as many real-time communication frameworks provide means for reacting to disconnecting peers. The problem is that this probably would mean that the user needs to interact with the internal client identifiers.
  • Handle automatically when a peer hasn't sent an update for a while (considering the state message interval Send periodical state messages from inactive clients #5).
@pekam pekam added the enhancement New feature or request label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant