Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google App Engine Deployment in Readme is not Right: #442

Open
catosaurusrex2003 opened this issue Feb 1, 2024 · 1 comment
Open

Google App Engine Deployment in Readme is not Right: #442

catosaurusrex2003 opened this issue Feb 1, 2024 · 1 comment
Labels
server

Comments

@catosaurusrex2003
Copy link

Google App Engine Deployment in Readme is not Right:

  • The node Version needs to be correct for it.
  • peer version 1.0.2
  • Nodejs version: NAN. i am using google app engine how it is defined in Readme and this issue is related to nodejs version itself.
  • Platform name: Google App Engine.

ERROR

image

i am using the exact same app.yaml and package.json mentioned in the Readme.md

What is wrong?

The node version in google app engine is by default node 12. Which doesnt support the ?. operator.
?. operators is supported in node version 14 and above.

How to fix this?

I will be opening a Pull Request to fix this
@catosaurusrex2003 catosaurusrex2003 mentioned this issue Feb 1, 2024
Open
@irgalamarr irgalamarr added the bug label Feb 24, 2024 — with Linear
@irgalamarr irgalamarr added server and removed bug labels Feb 24, 2024
catosaurusrex2003 added a commit to catosaurusrex2003/peerjs-server that referenced this issue Apr 13, 2024
@catosaurusrex2003
feat: Updated Google App Engine Setup in app.yaml in the Readme.md - p…
55c6deb 
…eers#442 issue
catosaurusrex2003 added a commit to catosaurusrex2003/peerjs-server that referenced this issue Apr 13, 2024
@catosaurusrex2003
feat: Updated Google App Engine Setup in app.yaml in the Readme.md - p…
dd361aa 
…eers#442 issue
@catosaurusrex2003
Copy link
Author

i have created a PR with a very small change in the Readme.md
#443
pls verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@irgalamarr @catosaurusrex2003