Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement payload validation #208

Open
prabhu opened this issue Jul 27, 2020 · 0 comments
Open

Implement payload validation #208

prabhu opened this issue Jul 27, 2020 · 0 comments
Labels

Comments

@prabhu
Copy link

prabhu commented Jul 27, 2020

Thank you for this library.

While reviewing this project with ShiftLeft, I came across an insight pointing to this code

https://github.com/peers/peerjs-server/blob/master/src/api/v1/calls/index.ts#L20

It appears like the payload object has no type, sanitization or validation anywhere in the server and is left purely to the end client application to perform their own. It will be nice if there is a possibility to add some default validators and ability to add custom validators since it is not clear if all end user applications have both sanitization and validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants