Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop default=0 from concrete model foreignkey definitions #49

Open
vegu opened this issue Jul 1, 2020 · 3 comments
Open

Drop default=0 from concrete model foreignkey definitions #49

vegu opened this issue Jul 1, 2020 · 3 comments
Assignees
Labels
bug Major 4 - 10 hours work

Comments

@vegu
Copy link
Contributor

vegu commented Jul 1, 2020

Not sure why they are there, none of the fields are allowed to be 0, and its quite possibly the reason AlterField migrations for those fields break when the database backend is mysql

Relates to #46

@grizz
Copy link
Member

grizz commented Sep 4, 2020

@peeringdb/pc This is a bug, and also a very likely rabbit hole. :) We should probably tackle it sooner rather than later however.

@grizz grizz added bug Major 4 - 10 hours work labels Sep 4, 2020
@grizz grizz added this to the 4 Ready for Implementation milestone Sep 4, 2020
@shane-kerr
Copy link

+1

@paravoid
Copy link
Contributor

Not sure if we need a separate task to track this, but the removal of the migrations in 7ddb49f (which was a fallout of #45, for reasons that are related to the present issue) is causing a problem, where running "makemigrations" (even on a downstream project!) creates a new auto migration under django_peeringdb that alters all the fields…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Major 4 - 10 hours work
Projects
None yet
Development

No branches or pull requests

4 participants