Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation & easier way to set up sync for a project #43

Open
paravoid opened this issue May 2, 2020 · 1 comment
Open

Better documentation & easier way to set up sync for a project #43

paravoid opened this issue May 2, 2020 · 1 comment
Labels
No code change Fixing the issue will not require touching the code

Comments

@paravoid
Copy link
Contributor

paravoid commented May 2, 2020

(First off, the doc.md instructions are outdated, still pointing at pdb_sync, which is deprecated since v1.0.0.)

Moving the sync code to the peeringdb CLI to provide a more loose coupling is understandable. However, AIUI, this puts downstream users in the odd position of having to set up peeringdb CLI configuration (using e.g. peeringdb config set), with the exact same database and API username/password information as their project, run the sync, then have the (downstream) Django code also use the same database almost separately. Have I misunderstood how this is supposed to work?

It'd be neat if there was a better integration between the two projects. That is, for example, if there was a way for the pdb_sync management command to be restored, but make it a simple proxy to "peeringdb sync", while also giving the ability to use the configuration (settings.py) from one's project, including the database configuration. Would something like that make sense?

@grizz grizz added this to the 4 Ready for Implementation milestone Sep 4, 2020
@grizz grizz added the No code change Fixing the issue will not require touching the code label Sep 4, 2020
@dafrandle
Copy link

dafrandle commented Jan 3, 2025

going to resurrect this.
having to make my Celery task use subprocess to call the sync has been a massive headache for me.

The outdated documentation has only been the icing on that.

I really struggle to understand why this repo even exits since, as I understand it, the peeringdb-py project will also make the tables which is the only thing this repo can even do as far as I can tell. You only need to make the tables once, so this repo is not even that useful.

If I can't call the sync, and I can't use my Django settings, or. env in my project to configure the sync, what is it exactly that this repo is actually trying to achieve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No code change Fixing the issue will not require touching the code
Projects
None yet
Development

No branches or pull requests

3 participants