Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I suggest some fixes & imrovements #3

Open
QuietNoise opened this issue Jun 3, 2021 · 0 comments
Open

I suggest some fixes & imrovements #3

QuietNoise opened this issue Jun 3, 2021 · 0 comments

Comments

@QuietNoise
Copy link

Registration plate:
Line 417:
$regex = '/^(\d{2,3})[\ -]([A-Z][A-Z]?)[\ -]\d{1,6}$/';
The regex should allow for reg without spaces / special characters. I.e. make them optional
$regex = '/^(\d{2,3})[\ -]?([A-Z][A-Z]?)[\ -]?\d{1,6}$/';

Line 448:
if (!Validate_IE::yearBetween87and12($year)) {
Function continues to check years for 2 digit plates rather than 3 digit ones (which should be just greater that year 12. I reckon the line could just be:

if ($year < 13) {
	return false;
}
@QuietNoise QuietNoise changed the title I suggest som fixes 7 imrovements I suggest some fixes & imrovements Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant