Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subtitles #6

Open
pcwalton opened this issue Feb 20, 2015 · 5 comments
Open

Support subtitles #6

pcwalton opened this issue Feb 20, 2015 · 5 comments

Comments

@pcwalton
Copy link
Owner

Subtitles are currently not supported, but they should be.

@SimonSapin
Copy link

What’s the scope of this? In a standalone media player, "subtitle support" might involve:

  1. Decoding various file formats
  2. Font management
  3. Text layout (including line breaking) and rendering
  4. Overlay/compositing on top of video frames

The first item should definitely be part of rust-media, but in the context of Servo everything else can (and should) be achieved by having the text be rendered as if it was in an HTML element. So all that logic should not be duplicated in rust-media. However this may not be idea for non-Servo users.

@pcwalton
Copy link
Owner Author

I've been thinking that rust-media can accept features that are outside the scope of Servo, but they go behind Cargo features so that we can compile them out for Servo.

@pcwalton
Copy link
Owner Author

That said, line breaking and text layout may want to be a separate crate entirely.

@SimonSapin
Copy link

Something like Pango? Yes, that would probably be useful to the Rust ecosystem at large. But I suggest we consider out of scope for rust-media at first, and reconsider if/when someone asks for it. A non-Servo user might happen to be using a UI toolkit that already does text rendering.

@pcwalton
Copy link
Owner Author

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants