Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termbuf API review #16

Open
czchen opened this issue Aug 5, 2015 · 3 comments
Open

termbuf API review #16

czchen opened this issue Aug 5, 2015 · 3 comments
Milestone

Comments

@czchen
Copy link
Member

czchen commented Aug 5, 2015

Need to review new termbuf API used by ansiparser2.

        termbuf = {
            puts: () => {},

            scrollUp: () => {},
            scrollDown: () => {},
            setScrollRegion: () => {},

            handleCR: () => {},
            handleLF: () => {},
            handleInsert: () => {},
            handleTab: () => {},
            handleClear: () => {},
            handleDel: () => {},
            handleBackTab: () => {},

            eraseLine: () => {},
            insertLine: () => {},
            deleteLine: () => {},
            eraseChar: () => {},

            setAttribute: () => {},

            gotoPos: () => {},
            gotoHorizon: () => {},
            gotoVertical: () => {},
            movePos: () => {},

            saveCursor: () => {},
            restoreCursor: () => {},

            getRow: () => { return 24; },
            getColumn: () => { return 80; },
        };
@czchen czchen added this to the v0.1.0 milestone Aug 5, 2015
@czchen
Copy link
Member Author

czchen commented Aug 5, 2015

setAttribute shall split to resetAttribute, setUnderline, setBlink, setForegroundColor, setBackgroundColor, ...

@kidwm
Copy link
Member

kidwm commented Aug 5, 2015

getRow & getColumn 要不要改 getRowsCount & getColumnsCount 比較明確啊?

@czchen
Copy link
Member Author

czchen commented Aug 5, 2015

Sound great.

getRow -> getRowsCount
getColumn -> getColumnsCount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants